code-423n4 / 2024-03-coinbase-findings

1 stars 0 forks source link

QA Report #186

Closed c4-bot-8 closed 8 months ago

c4-bot-8 commented 8 months ago

See the markdown file with the details of this report here.

raymondfam commented 8 months ago

L001: Impractical suggestions except for _authorizeUpgrade. L002: Bot on [L-14] Unused/empty receive()/fallback() function L003: Bot on [N-44] Multiple type casts create complexity within the code L004: Bot on [L-04] constructor/initialize function lacks parameter validation L005: Bot on [N-26] For loops in public or external functions should be avoided due to high gas costs and possible DOS L006, L007: See L005 L008: See L004 L012: Bot on [L-02] Consider bounding input array length NC001: Bot on [N-28] Function ordering in the contract does not follow the Solidity style guide NC002: [D-26] Unused named return variables without optimizer waste gas NC004: These are local variables. NC006: Bot on [N-39] Long functions should be refactored into multiple, smaller, functions NC009: False positive. require is only found in the comments. NC010: onlyOwner visibility is all it needs

The rest of the findings are generally generic and reported by other many other bots.

c4-pre-sort commented 8 months ago

raymondfam marked the issue as sufficient quality report

c4-judge commented 8 months ago

3docSec marked the issue as grade-c