Open c4-bot-8 opened 5 months ago
See #61.
raymondfam marked the issue as sufficient quality report
raymondfam marked the issue as duplicate of #18
raymondfam marked the issue as duplicate of #22
raymondfam marked the issue as not a duplicate
raymondfam marked the issue as duplicate of #57
3docSec marked the issue as not a duplicate
3docSec marked the issue as duplicate of #18
3docSec changed the severity to QA (Quality Assurance)
3docSec marked the issue as grade-a
Lines of code
https://github.com/code-423n4/2024-03-coinbase/blob/main/src/SmartWallet/MultiOwnable.sol#L77
Vulnerability details
Impact
The initial owner of CoinbaseSmartWallet can use MultiOwnable.sol addOwnerAddress() to add a new owner address. onlyOwner modifier use _checkOwner to ensure the caller is an authorized owner
isOwnerAddress() checks if the given account address is registered as owner.
Consider this senario:
Proof of Concept
https://github.com/code-423n4/2024-03-coinbase/blob/main/src/SmartWallet/MultiOwnable.sol#L77
Tools Used
Recommended Mitigation Steps
only initial owner of smart wallet can add/remove new address as owner
Assessed type
MEV