search

code-423n4 / 2024-03-dittoeth-findings

0 stars 0 forks source link

QA Report #290

Open c4-bot-1 opened 3 months ago

c4-bot-1 commented 3 months ago

See the markdown file with the details of this report here.

raymondfam commented 3 months ago

L1, L2, L7, L8, L18, L24-29: Insufficient proof/elaboration L3, L4, L6: Check the doc for the selected/intended uint type L5: mul and div each has its proper scaling in place in the library L12: function would revert anyway if ercAmount * price is less than the minimum dust L13: Loop cap should be implemented in calling functions invoking bidMatchAlgo() L14: Checks are well in place in LibOrders and LibOracles.

12 L/NC.

c4-pre-sort commented 3 months ago

raymondfam marked the issue as sufficient quality report

c4-sponsor commented 3 months ago

ditto-eth (sponsor) acknowledged

c4-judge commented 2 months ago

hansfriese marked the issue as grade-b