PR10 MitigationConfirmed

[liveactionllama]

This adds convenience functions to handle multiple community stakes in 1 call: multipleCommunityStakes, extendMultipleCommunityStake and withdrawMultipleCommunityStake

Overall there is not much for review on this changes, we are implementing a simple function on top of an old which was previously audited.

• multipleCommunityStakes - calls the internal function _communityStake multiple times depending on the stakee's length, the reason for this new function is to allow users to make multiple community stakes in a single transaction. As a security measure we already check that the provided user values correspondant to the identical number of all of them.

  function multipleCommunityStakes(
    address[] calldata stakees,
    uint88[] calldata amounts,
    uint64[] calldata durations
  ) external whenNotPaused {
    if (stakees.length != amounts.length || stakees.length != durations.length) {
      revert ArrayLengthMismatch();
    }

    for (uint i = 0; i < stakees.length; i++) {
      _communityStake(stakees[i], amounts[i], durations[i]);
    }
  }

• extendMultipleCommunityStakes - extends the duration of an existing comminty stake, the system also makes sure that there is no mismach between the inputed user values to confirm correct behaviour.

  function extendMultipleCommunityStakes(
    address[] calldata stakees,
    uint64[] calldata durations
  ) external whenNotPaused {
    if (stakees.length != durations.length) {
      revert ArrayLengthMismatch();
    }

    for (uint i = 0; i < stakees.length; i++) {
      _extendCommunityStake(stakees[i], durations[i]);
    }
  }

• withdrawMultipleCommunityStakes - provides a way for users to withdraw multiple community stakes in the same transaction, a further check is made to ensure there is not mismach between the inputted values by the user for extra security.

  function withdrawMultipleCommunityStakes(
    address[] calldata stakees,
    uint88[] calldata amounts
  ) external whenNotPaused {
    if (stakees.length != amounts.length) {
      revert ArrayLengthMismatch();
    }
    uint88 totalAmountToWithdraw = 0;

    for (uint i = 0; i < stakees.length; i++) {
      _prepareWithdrawCommunityStake(stakees[i], amounts[i]);

      totalAmountToWithdraw += amounts[i];
    }

    if (!token.transfer(msg.sender, totalAmountToWithdraw)) {
      revert FailedTransfer();
    }
  }

By looking at the code l can confirm by implementing this changes there is no issues occurring.

[liveactionllama]

Note: per discussion with the judge, sponsor, and participating wardens, the full scope for this competition was initially a bit unclear. As such, the participating wardens have all agreed to review items outside of the original active competition phase. Adding their work to this findings repo for further review by all parties.

[c4-judge]

GalloDaSballo marked the issue as satisfactory