search

code-423n4 / 2024-03-pooltogether-findings

5 stars 4 forks source link

Gas Optimizations #343

Closed c4-bot-6 closed 5 months ago

c4-bot-6 commented 5 months ago

See the markdown file with the details of this report here.

raymondfam commented 5 months ago

G1: No gas savings possible as address is 20 bytes and not packable with any other state variable listed G2: making them private defeats the purpose as public getters by default would be desirable G6: (_amountOut + _yieldFee > _availableYield) can't be executed without _yieldFee first calculated G7: The state variables given would all need to be updated and assigned when needed.

3 G

c4-pre-sort commented 5 months ago

raymondfam marked the issue as insufficient quality report

c4-pre-sort commented 5 months ago

raymondfam marked the issue as grade-c