code-423n4 / 2024-03-saltyio-mitigation-findings

0 stars 0 forks source link

E1 MitigationConfirmed #120

Open c4-bot-4 opened 4 months ago

c4-bot-4 commented 4 months ago

Lines of code

Vulnerability details

Mitigation

commit f16623e The mitigation introduced a new function Pools#depositZapSwapWithdraw(). Unlike depositSwapWithdraw() and depositDoubleSwapWithdraw(), arbitrage doesn't occur in depositZapSwapWithdraw(). It will be used in Liquidity#depositLiquidityAndIncreaseShare() for imbalanced amounts zapping. Zapping amount is limited to less than 1% of the reserve to mitigate slippage risk.

Conclusion

LGTM

c4-judge commented 4 months ago

Picodes marked the issue as satisfactory