search

code-423n4 / 2024-03-saltyio-mitigation-findings

0 stars 0 forks source link

E5 MitigationConfirmed #37

Open c4-bot-5 opened 5 months ago

c4-bot-5 commented 5 months ago

Lines of code

https://github.com/othernet-global/salty-io/blob/main/src/pools/Pools.sol#L65

Vulnerability details

Summary

The provided PR in E5 attempts to limit the number of swaps to one per block to prevent bypassing arbitrage within a single block.

Analysis

The changes made in the PR like this one or this are not present in the final codebase given as part of the audit.

Although the codebase contains modifications on top of the PR, the PR achieves the task of implementing what it set out to. It must additionally be said that in this particular case even though the final codebase is not exactly the same as the PR, it still contains the correct logic too albeit with different modifier & variable names. So the effect of the mismatch is negligible.

Conclusion

LGTM

Assessed type

Other

c4-judge commented 5 months ago

Picodes marked the issue as satisfactory