code-423n4 / 2024-03-saltyio-mitigation-findings

0 stars 0 forks source link

M-14 MitigationConfirmed #79

Open c4-bot-3 opened 4 months ago

c4-bot-3 commented 4 months ago

Lines of code

Vulnerability details

Comments

In the original implementation, The finalization of a voting-ended whitelisting proposal could be postponed by an in-progress whitelisting proposal due to incorrect loop checking.

Mitigation

commit ccf4368 The mitigation removed Proposals#tokenWhitelistingBallotWithTheMostVotes(). Any whitelisting proposal that has reached quorum with sufficient approval votes can be finalized immediately. The original issue was resolved.

Conclusion

Confirmed

c4-judge commented 4 months ago

Picodes marked the issue as satisfactory

c4-judge commented 4 months ago

Picodes marked the issue as confirmed for report