search

code-423n4 / 2024-03-saltyio-mitigation-findings

0 stars 0 forks source link

M-02 MitigationConfirmed #9

Open c4-bot-10 opened 7 months ago

c4-bot-10 commented 7 months ago

Lines of code

Vulnerability details

Lines of code

https://github.com/othernet-global/salty-io/blob/main/src/dao/DAO.sol#L141-L146

Vulnerability details

Existing Vulnerability details

M-02 stated that L180, which is an external contract call, was not surrounded in a try-catch block and hence if it reverted permanently, the ballot finalization got stuck.

Mitigation

The fix has implemented a try-catch now thus handling the issue.

Conclusion

LGTM

c4-judge commented 7 months ago

Picodes marked the issue as satisfactory

c4-judge commented 7 months ago

Picodes marked the issue as confirmed for report