search

code-423n4 / 2024-03-zksync-findings

1 stars 1 forks source link

QA Report #109

Open c4-bot-7 opened 4 months ago

c4-bot-7 commented 4 months ago

See the markdown file with the details of this report here.

c4-judge commented 2 months ago

alex-ppg marked the issue as grade-b

thenua3bhai commented 2 months ago

Hi @alex-ppg Thanks for judging

[L-09] in this QA report is a duplicate of #77 and can be upgraded to medium. This is the similar issue of state var. not set during initialization but in different file.
issue 77 states that l1LegacyBridge is not set in L2SharedBridge While [L-09] in this QA report states that l2Bridge and other two state variables are not set in L1ERC20Bridge.sol initialize function. Also they are never initialized inside contract using any function, only used directly as their by default value 0. Thanks

alex-ppg commented 2 months ago

Hey @thenua3bhai, thanks for contributing to the PJQA process. L-09 is invalid because the referenced variables are meant to indicate storage slots that are used by the previous L1ERC20Bridge implementation, as the L1ERC20Bridge represents an upgrade.