code-423n4 / 2024-03-zksync-findings

1 stars 1 forks source link

Gas Optimizations #54

Closed c4-bot-6 closed 4 months ago

c4-bot-6 commented 5 months ago

See the markdown file with the details of this report here.

saxenism commented 4 months ago

Poor report. Bad style of writing. Nothing new.

c4-sponsor commented 4 months ago

saxenism (sponsor) acknowledged

c4-judge commented 4 months ago

alex-ppg marked the issue as grade-c

0xhacksmithh commented 4 months ago

@alex-ppg sir, i believe my report judged incorrectly, i provided description where it necessary, and one-liner where it enough to get that point. There are some unique points(optimization) which many of grade-a report are missing. i like give some example like Gas Point - 1 , 2, 5, 6, 9, 14, 15, 35

And others are valid optimization points i believe

alex-ppg commented 4 months ago

Hey @0xhacksmithh, thanks for contributing to the PJQA process. The report contains multiple formatting errors to consider it acceptable, and while there are some findings that provide value others are outright invalid like Gas-1, and Gas-6 (revert scenario optimizations are not accepted), The formatting errors are so severe that findings such as Gas-14 become illegible, diminishing the output of the report greatly. I advise paying closer attention to the overall report format in your future submissions and consider the present grade as final for this report.

0xhacksmithh commented 4 months ago

Hi @alex-ppg , i think this report should deserve atleast a grade-b, because there are so many valid optimization, as you mentioned only some will not accepted as formating error, they will fall under acknowledge section, i think out of 42 lots of them are valid by visiting other accepted reports

yaa report format was not that good, but believe each one describing thier purpose correctly, and some has required explanation as well. We previously see so many this type oneliner(common bug oneliner) accepted for reward.

Yaa taking your advise, and from next time i will give more time to report formating. thanks