search

code-423n4 / 2024-04-ai-arena-mitigation-findings

0 stars 0 forks source link

ADD-04 MitigationConfirmed #62

Open c4-bot-9 opened 5 months ago

c4-bot-9 commented 5 months ago

Lines of code

Vulnerability details

C4 issue

ADD-04: QA Report 1490

Comments

The QA Report 1490 mentions 14 low and informational issues. ADD-04 takes care of only 2 low severity issues mentioned in the report.

Mitigation

PR #14 L-05 and L-06 have been fixed in this commit. Now it's possible to have a NRN total supply equal to Neuron's MAX_SUPPLY and globalStakedAmount is correctly updated when a new round is set, discounting the total stake at risk of the previous round.

The fix of M-06 was also included in this commit.

Suggestion

None

Conclusion

LGTM

c4-judge commented 5 months ago

jhsagd76 marked the issue as satisfactory