Upgraded Q -> 2 from #1082 [1714929308125]

[c4-judge]

Judge has assessed an item in Issue #1082 as 2 risk. The relevant finding follows:

[L-02] Remove Vault can be susceptible to dos in the function remove

function remove( uint id, address vault ) external isDNftOwner(id) { if (Vault(vault).id2asset(id) > 0) revert VaultHasAssets(); if (!vaults[id].remove(vault)) revert VaultNotAdded(); emit Removed(id, vault); }

if (Vault(vault).id2asset(id) > 0) revert VaultHasAssets(); will cause revertion if a attacker deposits to the vault making the user not be able remove the vault, resulting in dos.

[c4-judge]

koolexcrypto marked the issue as duplicate of #489

[c4-judge]

koolexcrypto marked the issue as unsatisfactory: Invalid

[c4-judge]

koolexcrypto marked the issue as nullified

[c4-judge]

koolexcrypto marked the issue as not nullified

[c4-judge]

koolexcrypto marked the issue as duplicate of #1001

[c4-judge]

koolexcrypto marked the issue as satisfactory

[c4-judge]

koolexcrypto changed the severity to 3 (High Risk)