code-423n4 / 2024-04-gondi-findings

0 stars 0 forks source link

Upgraded Q -> 2 from #82 [1713691250926] #84

Closed c4-judge closed 7 months ago

c4-judge commented 7 months ago

Judge has assessed an item in Issue #82 as 2 risk. The relevant finding follows:

Low-15 Collected fees are locked in the contract due to no sweeping or claiming methods

Instances(1) In src/lib/pools/Pool.sol, fees are collected during loan repayments or loan liquidation flows and added to uint256 public getCollectedFees;. However, there are no methods to collect these fees, causing fees to be locked.

Recommendations: Add a method to claim getCollectedFees.

c4-judge commented 7 months ago

0xA5DF marked the issue as satisfactory

c4-judge commented 7 months ago

0xA5DF marked the issue as duplicate of #60