c4-bot-9 commented 4 months ago

Lines of code

https://github.com/code-423n4/2024-04-panoptic/blob/main/contracts/CollateralTracker.sol#L480

Vulnerability details

Impact

The maxMint function, which is intended to limit the amount of shares that can be minted based on the total supply of shares and the current pool utilization. The absence of the proper use for maxMint could lead to scenarios where users are able to mint more shares than intended, potentially leading to imbalances in the system or even allowing for the minting of an excessive number of shares beyond the protocol's limits. This does have low impact in imbalance of tokens in the system but high possibility.

Proof of Concept

https://github.com/code-423n4/2024-04-panoptic/blob/main/contracts/CollateralTracker.sol#L480

type(uint104).max > [assets to be minted] > maxMint

and type(uint104).max * totalSupply/totalAssets *dec/(dec+fee) <= maxMint

so for totalSupply <= totalAssets,

we can say maxMint < type(uint104).max

then the first can be true at any time

Tools Used

Manual Review

Recommended Mitigation Steps

The function should ensure that the maximum number of shares that can be minted does not exceed the protocol's set limits, as defined by maxMint

Assessed type

Other

c4-judge commented 4 months ago

Picodes marked the issue as duplicate of #553

c4-judge commented 4 months ago

Picodes marked the issue as satisfactory

c4-judge commented 3 months ago

Picodes changed the severity to QA (Quality Assurance)