c4-bot-5 commented 4 months ago

Lines of code

Vulnerability details

C4 Issue

M-05: setReserveFactor fails to update global interest before updating reserve factor

Issue Details

Calling V3Vault::setReserveFactor() did not update the global interest rate before setting the new value for reserveFactorX32 - as a result the value was applied retroactively to the lender exchange rate, causing unexpected conditions for lenders

Mitigation

PR-23 successfully mitigates the original issue by calling _updateGlobalInterest() inside V3Vault::setReserveFactor() before updating the reserve factor.

Conclusion

Mitigation Confirmed

c4-judge commented 4 months ago

jhsagd76 marked the issue as satisfactory