search

code-423n4 / 2024-04-revert-mitigation-findings

1 stars 1 forks source link

M-21 MitigationConfirmed #55

Open c4-bot-7 opened 5 months ago

c4-bot-7 commented 5 months ago

Lines of code

Vulnerability details

C4 Issue

M-21: Dangerous use of deadline parameter

Issue Details

The protocol was using block.timestamp as the deadline argument when interacting with the Uniswap NFT Position Manager, making those transactions more vulnerable.

Mitigation

PR-24 successfully mitigates the original issue by replacing hardcoded block.timestamp with input provided deadline throughout the codebase where Position Manager is interacted with.

Conclusion

Mitigation Confirmed

c4-judge commented 5 months ago

jhsagd76 marked the issue as satisfactory