search

code-423n4 / 2024-04-revert-mitigation-findings

1 stars 1 forks source link

M-24 MitigationConfirmed #57

Open c4-bot-8 opened 3 months ago

c4-bot-8 commented 3 months ago

Lines of code

Vulnerability details

C4 Issue

M-24: Incorrect liquidation fee calculation during underwater liquidation...

Issue Details

The problem here was that liquidator reward calculations for underwater positions deviated from the economic model outlined in the protocol docs.

According to docs liquidation fee for underwater positions is 10% of the debt, however the V3Vault.sol calculated the liquidation fee as 10% of the collateral value left in the position rather than 10% of the debt. Since the collateral value is lower than the debt, this reduces the incentive for liquidators

Mitigation

PR-7 successfully mitigates the original issue by updating the liquidation fee to be calculated from the debt, instead of the collateral value left.

Conclusion

Mitigation Confirmed

c4-judge commented 2 months ago

jhsagd76 marked the issue as satisfactory