code-423n4 / 2024-04-revert-mitigation-findings

1 stars 1 forks source link

ADD-03 MitigationConfirmed #61

Open c4-bot-10 opened 5 months ago

c4-bot-10 commented 5 months ago

Lines of code

Vulnerability details

C4 Issue

ADD-03: Some ERC20 can revert on a zero value transfer

Issue Details

The protocol did not implement 0 amount checks before transferring tokens. This can lead to DOS of the function executing a transfer in case the token reverts on zero value transfers.

Mitigation

PR-28 includes the refactoring only for one of the contracts(AutoCompound.sol). However I analyzed all contracts in the audit branch and it seems all token transfer instances have been properly refactored.

Conclusion

Mitigation Confirmed

c4-judge commented 5 months ago

jhsagd76 marked the issue as satisfactory