c4-bot-2 commented 5 months ago

Lines of code

Vulnerability details

ADD-05: QA, GAS

This issue resolves several QA and gas issues.

PR #33

The mitigation includes:

Add a Constants abstract class which contains misc constants and is inherited throughout various contracts. This change allows Revert to remove various constants from various contracts since it's now located in the Constants abstract class.
Move immutable state variables to top of contract.
Remove unnecessary default variable assignments.
LeverageTransformer.leverageDown() resets approval when repaying the vault.
Minor code linting.
Utilize ERC20 safeApprove over safeIncreaseAllowance
Other misc changes.

All changes are safe and do not impact functionality in a negative way.

LGTM

c4-judge commented 5 months ago

jhsagd76 marked the issue as satisfactory

c4-judge commented 5 months ago

jhsagd76 marked the issue as confirmed for report