Open howlbot-integration[bot] opened 1 month ago
Picodes marked the issue as grade-a
Picodes marked the issue as grade-c
Picodes marked the issue as grade-a
This report's formatting is good but reported issues aren't that valuable as they mainly come from static analysis
Hello there @Picodes
I would like to respectfully claim this is a QA report, that is worthy of the grade A it was given and is worthy of the top 3 based on:
The following reasons =
I claim the majority are valid and utilising them will better improve the contracts, debugging, documentation and clarity of use.
I claim all can be considered low, I used the umbrella of NC as I was unaware of the recent updates. Which I have noted for next time. Given this I move to claim they are all worthy of the Low label. As low vs non critical is a blurry line.
I do not see any as invalid in my own analysis. All 43 to me I deem valid. But am open to critics with sufficient proof, that would better improve the quality and value of the report next time. And I would also like to add these were not done, from static analysis. For obvious reasons I will not breakdown my process.
My claim here is simply they are valuable with respect to the contracts. And comparatively with the other reports. Which offer great value to. And that given the 43 suggestions, I claim the majority of my suggestions are valid and useful. And therefore the label It has been given is valid, and I see my report as worthy of the top 3 comparatively with the other grade A reports. Which are very good. I do not make any claims in my report that exaggerate or assert false potentials. And stuck to an unbiased process. As best as I could.
All the best - K
@CrystallineButterfly most of the issues are definitely NC. Note that the 3 reports haven't been selected yet and will be chosen following a vote between the judge and the validators
Ok thank you @Picodes 🙏
See the markdown file with the details of this report here.