search

code-423n4 / 2024-05-bakerfi-findings

4 stars 4 forks source link

QA Report #45

Open c4-bot-9 opened 5 months ago

c4-bot-9 commented 5 months ago

See the markdown file with the details of this report here.

hvasconcelos commented 5 months ago

[L-01] Not returning excess ETH when updating price of Pyth Oracles - Confirmed [L-02] Not enough Sanity checks to validate the data pulled from the Pyth Oracle - Acknowledged [L-03] Privileged functions on the StrategyLeverageSettings contract are callable only by the Governor instead of the Owner - Acknowledged [L-04] Price updates made on the last not-stale block would be threated as if the price would already be stale, causign calls to revert because of priceOutdated. Confirmed [L-05] Unnecessary approval of steth to uniRouter in the StrategyAAVEv3WSTETH contract. Confirmed [L-06] Contracts are incompatible with ERC20 on-fee transfer tokens Acknowledged [L-07] Incorrect operator causes tx to revert when validating the value of loanToValue in calculateLeverageRatio() function - Confirmed [L-08] Not allowed to prevent liquidations by rebalancing the vault while vault is paused - Disputed - We have the pause function to prevent any agent to interact with the protocol

c4-judge commented 5 months ago

0xleastwood marked the issue as grade-a

ickas commented 5 months ago

[L-01] fixed → https://github.com/baker-fi/bakerfi-contracts/pull/53

ickas commented 5 months ago

[L-02] fixed → https://github.com/baker-fi/bakerfi-contracts/pull/55

ickas commented 5 months ago

[L-04] fixed → https://github.com/baker-fi/bakerfi-contracts/pull/56

ickas commented 5 months ago

[L-05] fixed → https://github.com/baker-fi/bakerfi-contracts/pull/57

ickas commented 5 months ago

[L-07] fixed → https://github.com/baker-fi/bakerfi-contracts/pull/58

thebrittfactor commented 5 months ago

For awarding purposes, C4 staff have marked as 2nd place.