search

code-423n4 / 2024-05-gondi-mitigation-findings

0 stars 0 forks source link

M-08 MitigationConfirmed #26

Open c4-bot-8 opened 6 months ago

c4-bot-8 commented 6 months ago

Lines of code

Vulnerability details

Comments

in the previous implementation

In extreme cases, emitLoan() can reuse signatures, but it must satisfy the following conditions:

  1. The expiration time is set too long.
  2. The user has repaid the previous amount and has set NFT authorization.

Since the situation is quite extreme, the choice is not to modify the code, which I personally think is acceptable. However, add a comment

Only adding a comment here. Borrower should always set block.timestamp +small time delta as expiration to control when the loan can be started.

c4-judge commented 6 months ago

alex-ppg marked the issue as satisfactory