Closed howlbot-integration[bot] closed 3 months ago
alex-ppg marked the issue as not a duplicate
The Warden claims that a stalemate may occur similarly to #92 and thus is considered to be an invalid submission for the same reasons.
alex-ppg marked the issue as unsatisfactory: Invalid
Lines of code
https://github.com/code-423n4/2024-05-munchables/blob/main/src/managers/LockManager.sol#L142-L242
Vulnerability details
Vulnerability details
A stalemate can occur if 2 users approve and 2 users disapprove a proposal, making the contract ineffective as no new proposals can be made or resolved.
Impact
Proof of Concept
Users with the
pricefeed_n
role can create a proposal. If 2 users approve and 2 users disapprove, the proposal remains unresolved because 2 votes are less than both theAPPROVE_THRESHOLD
andDISAPPROVE_THRESHOLD
. Since the same address cannot both approve and disapprove, the proposal cannot be dropped, leading to a deadlock. This makes the contract ineffective.Tool used
Manual
Recommended Mitigation Steps
Possible Solutions
APPROVE_THRESHOLD
andDISAPPROVE_THRESHOLD
to reduce the likelihood of a stalemate.Assessed type
Other