search

code-423n4 / 2024-05-munchables-validation

0 stars 0 forks source link

QA Report #531

Open c4-bot-6 opened 6 months ago

c4-bot-6 commented 6 months ago

See the markdown file with the details of this report here.

niser93 commented 5 months ago

Hi @alex-ppg! This QA was not validated. However, I think it should have a second look. In L4, I reported a problem that is quite similar to 2024-05-munchables-findings #495, that was judged as Medium: I reported it as Medium because price feed role is trusted, and even if a price feed role has a wrong behavior, the admin can create new addresses and assign them the price feed role to avoid deadlock.

Furthermore, the other QA issues I reported are in other QA reports which were judged as grade-A. Could you please review this report? Thanks in advance

alex-ppg commented 5 months ago

Hey @niser93, thanks for your feedback! I reviewed this QA report after the validators deemed it of insufficient quality, and am aligned with their assessment as the report does not contain many low-risk issues and paints otherwise negligible issues as low-risk, such as L3.