search

code-423n4 / 2024-05-olas-findings

13 stars 4 forks source link

QA Report #112

Open howlbot-integration[bot] opened 4 months ago

howlbot-integration[bot] commented 4 months ago

See the markdown file with the details of this report here.

c4-judge commented 4 months ago

0xA5DF marked the issue as grade-b

0xA5DF commented 3 months ago

Missing checks for address(0) in constructor/initializers

Missing checks for address(0) when updating state variables

Zero address checks are 'cheap quality' findings in the first place, don't try to inflate that using some more cheap tricks

Division before multiplication

Irrelevant for those cases

Also, avoid NCs