code-423n4 / 2024-06-renzo-mitigation-findings

0 stars 0 forks source link

H-02 MitigationConfirmed #41

Open c4-bot-9 opened 4 weeks ago

c4-bot-9 commented 4 weeks ago

Lines of code

Vulnerability details

Original Issue Summary

The OperatorDelegator.getTokenBalanceFromStrategy() incorrectly uses address(this) to check for the queued amount instead of address(token).

address(this) will always return 0, which means that queuedShares[address(token)] will not be accounted for.

Mitigation

This mitigation proposes the usage of address(token) instead of address(this):

-            queuedShares[address(this)] == 0
+            queuedShares[address(token)] == 0

Comments

This mitigation succesfully mitigates the original issue. The address of the token is used, which will succesfully get the underlying token amount from the amount of shares + queued withdrawal shares.

Suggestion

n/a

Conclusion

LGTM

c4-judge commented 4 weeks ago

alcueca marked the issue as satisfactory