search

code-423n4 / 2024-07-munchables-findings

5 stars 0 forks source link

QA Report #309

Closed howlbot-integration[bot] closed 1 month ago

howlbot-integration[bot] commented 1 month ago

See the markdown file with the details of this report here.

0xinsanity commented 1 month ago

L1: I disagree with this. If someone else unlocking their funds, we do not have a notPaused modifier around it. This is because we always want people to be able to unlock their funds. Since this is a downstream call from unlock(), a notPaused modifier would crash the unlock call which would be very bad. L2: lastUpdated should only change when the number of plots changes. A tax rate should not impact that. L3: Acknowledged L4: Fix: https://github.com/munchablesorg/munchables-common-core-latest/pull/new/fix/stake-revert. The check should be in stake though, not unstake/transfer L5: Acknowledged L6: Acknowledged

c4-judge commented 1 month ago

alex-ppg marked the issue as grade-c