Upgraded Q -> 2 from #50 [1722566951774]

c4-judge commented 3 months ago

Judge has assessed an item in Issue #50 as 2 risk. The relevant finding follows:

Low-06 When oracle’s CHALLENGE_PERIOD is greater than FDG’s MAX_CLOCK_DURATION, step challenge might be reverted due to unfinalized large preiamge proposals. Instances(1) An edge case is when CHALLENGE_PERIOD (preimageOracle) is greater than (MAX_CLOCK_DURATION), there is a chance large preiamge proposal cannot be finalized in preimageOracle due to CHALLENGE_PERIOD hasn’t passed.

This means that any step challenge that might consume the LPP from preimageOracle will cause revert, due to preimage not finalized in the oracle.

Recommendations: May consider add a check in PreimageOracle.sol’s constructor to ensure CHALLENGE_PERIOD is a reasonable value relative to current MAX_CLOCK_DURATION of deployed FDGs.

c4-judge commented 3 months ago

zobront marked the issue as duplicate of #29

c4-judge commented 3 months ago

zobront marked the issue as satisfactory

c4-judge commented 3 months ago

zobront removed the grade

c4-judge commented 3 months ago

This auto-generated issue was withdrawn by zobront

zobront commented 3 months ago

I was mistaken in upgrading this, as it is different from the issues I duplicated with and should be considered user error on the part of the admin for setting these values incorrectly. Moving back to QA.

c4-judge commented 3 months ago

This previously downgraded issue has been upgraded by zobront

c4-judge commented 3 months ago

zobront marked the issue as not a duplicate

c4-judge commented 3 months ago

This auto-generated issue was withdrawn by zobront

c4-judge commented 3 months ago

This previously downgraded issue has been upgraded by zobront

c4-judge commented 3 months ago

This auto-generated issue was withdrawn by zobront

code-423n4 / 2024-07-optimism-findings

Upgraded Q -> 2 from #50 [1722566951774] #122