search

code-423n4 / 2024-07-traitforge-findings

0 stars 0 forks source link

QA Report #1029

Open howlbot-integration[bot] opened 1 month ago

howlbot-integration[bot] commented 1 month ago

See the markdown file with the details of this report here.

c4-judge commented 1 month ago

koolexcrypto marked the issue as grade-a

TForge1 commented 1 month ago

L-01: the check is incorrect anyway so it just passes and doesn’t re-start L-05 this function is called by another mint function that assigns to tokenID to an address L-06 useless, the function won’t work anyway L-07 all entropies are supposed to be determinable and viewable. Not an issue. Doesn’t matter if it’s manipulated on write aswell because a miner has no upper hand than a random on etherscan viewing entropies. L-07 this entry is a lack of game understanding. Every entity will be different, hence value for some and less value for others. Nor should it be randomly decided, a digit from entropy is intended L-10 not an issue, it is supposed to be known the entire time, as seen on game UI L-13 the contract owns-controls the tokenID so a user cannot list it again as they technically don’t own it

thebrittfactor commented 3 weeks ago

For awarding purposes, C4 staff have marked as 2nd place.