search

code-423n4 / 2024-07-traitforge-findings

2 stars 1 forks source link

Upgraded Q -> 2 from #191 [1724083427475] #1048

Closed c4-judge closed 3 months ago

c4-judge commented 3 months ago

Judge has assessed an item in Issue #191 as 2 risk. The relevant finding follows:

Impact Cannot pause the contract in an emergency situation.

Proof of Concept The DevFund, EntityTrading, Airdrop, EntityForging, EntropyGenerator, NukeFund, and TraitForgeNft contracts inherit Pausable and use the whenNotPaused modifier. However, they do not have a public function that calls Pausable._pause. Therefore, it is practically impossible to pause these contracts.

Tools Used Manual Review

Recommended Mitigation Steps Create a public function in the contracts using Pausable that calls Pausable._pause so that the administrator can pause the contract.

c4-judge commented 3 months ago

koolexcrypto marked the issue as duplicate of #212

c4-judge commented 3 months ago

koolexcrypto marked the issue as satisfactory

c4-judge commented 3 months ago

koolexcrypto changed the severity to 3 (High Risk)

c4-judge commented 3 months ago

koolexcrypto changed the severity to 2 (Med Risk)