code-423n4 / 2024-08-superposition-findings

2 stars 1 forks source link

QA Report #166

Open howlbot-integration[bot] opened 2 months ago

howlbot-integration[bot] commented 2 months ago

See the markdown file with the details of this report here.

af-afk commented 2 months ago

https://github.com/code-423n4/2024-08-superposition-findings/blob/main/data/SBSecurity-Q.md#qa-01-operator-cannot-approve-via-ownershipnfts Is this a dupe?

https://github.com/code-423n4/2024-08-superposition-findings/blob/main/data/SBSecurity-Q.md#qa-02-get_liquidity_for_amounts-is-lowering-from-u256-to-int128 We won't make the change. This may by the case, but it's the callee's responsibility to ensure they're correctly calling the function.

https://github.com/code-423n4/2024-08-superposition-findings/blob/main/data/SBSecurity-Q.md#qa-03-sqrt-ratios-wont-overflow-on-time-due-to-u256-being-used-instead-of-u128 We suspect this is a dupe, but we'll investigate and make the recommended adjustments after some reflection if it makes sense.

af-afk commented 2 months ago

We updated the above.

c4-judge commented 2 months ago

alex-ppg marked the issue as grade-b