Incorrect Implementation of ERC721 Standard

[howlbot-integration[bot]]

Lines of code

https://github.com/code-423n4/2024-08-superposition/blob/4528c9d2dbe1550d2660dac903a8246076044905/pkg/sol/OwnershipNFTs.sol#L13

Vulnerability details

Vulnerability Details

The contract claims to implement IERC721Metadata, but it's missing several required functions from the ERC721 standard, such as supportsInterface(bytes4 interfaceId). This makes the contract non-compliant with the ERC721 standard.

Impact

Non-compliance with the ERC721 standard can lead to compatibility issues with wallets, marketplaces, and other contracts expecting a standard ERC721 token. This could result in tokens not being recognized or displayed correctly, potentially leading to loss of value or functionality for token holders.

Proof of Concept

The contract is missing the following required functions:

• supportsInterface(bytes4 interfaceId)
• totalSupply()
• tokenByIndex(uint256 index)
• tokenOfOwnerByIndex(address owner, uint256 index)

Tools Used

Manual Review

Recommended Mitigation Steps

Implement all required functions of the ERC721 standard. Consider using OpenZeppelin's ERC721 implementation as a base and extending it with your custom logic.

Assessed type

ERC721

[c4-judge]

alex-ppg changed the severity to QA (Quality Assurance)

[c4-judge]

alex-ppg marked the issue as grade-c

[c4-judge]

This previously downgraded issue has been upgraded by alex-ppg

[c4-judge]

alex-ppg changed the severity to QA (Quality Assurance)

[c4-judge]

alex-ppg marked the issue as grade-b