QA Report

[howlbot-integration[bot]]

See the markdown file with the details of this report here.

[udsene]

Hi @3docSec,

I think this QA report has not been evaluated. Just making a note here incase you have missed it.

Thank You

[3docSec]

Thanks for flagging, I did miss this one indeed.

1. Gas optimization -> NC
2. Not sure about this one, but reasonable -> OK
3. The scenario presented is a strange one... if a token is wrapped, the market owns the wrapping token, not the underlying -> Invalid
4. Intended behavior, why would the borrower not accept nice gifts :smile: -> Invalid
5. Looks no more than a naming question -> NC
6. The code's intention is to de-allocate the memory used when the function exits so no update is required -> Invalid
7. NC
8. NC
9. Borderline - lenders attack against their own interest as they earn interest from borrows -> OK
10. gas/NC -> Invalid
11. gas/NC -> Invalid
12. OK
13. Create2 address collision without elaboration of how likely a collision is -> Insufficient, even for an L
14. OK

[c4-judge]

3docSec marked the issue as grade-b

[udsene]

Hi @3docSec,

Thank you for the feedback! Will the other downgraded findings (to QA) of mine be considered during the final grade evaluation for this QA report ?