search

code-423n4 / 2024-08-wildcat-findings

3 stars 1 forks source link

QA Report #120

Closed howlbot-integration[bot] closed 1 month ago

howlbot-integration[bot] commented 2 months ago

See the markdown file with the details of this report here.

3docSec commented 1 month ago

Low 1 - little value added but OK Low 2 - invalid. With Weth on blast what fails is "WETH9.transferFrom(address(this), ....)" that unlike other chains requires approvals. "WETH9.transferFrom(msg.sender, ...)" behaves consistently. Low 3 - same as Low 1 Low 4 - this suggestion is actually harmful. It recommends saving gas on borrow by not initiating a transfer with 0 tokens. So it will spend the gas for checking all the time, to save gas in case the caller borrows 0. Same for the escrow, there can't be an escrow with no balance. Low 5 - invalid, the push is O(1) time (and gas) Low 6 - invalid, Revert on large approvals and/or transfers is out of scope as per README

Stopping here, the signal to noise ratio is too low.

c4-judge commented 1 month ago

3docSec marked the issue as grade-c