ADD-02 MitigationConfirmed

[c4-bot-2]

Lines of code

Vulnerability details

The change addresses the findings Malicious proposals can be executed in the Governance and StRSR era changes can be leveraged for governance attacks.

The fix applied, that is checking at proposal execution time that the proposal was not only voted but also created in the same era as the one it's being executed in, is consistent with the mitigation recommended in both findings.

While the fix introduces a small risk that also legitimate proposals are rejected, it adds an extra layer of security by forcing a minimum timeframe for StRSR to build a fair distribution of voting power after an era change before voting power is sampled for proposal voting.

[c4-judge]

thereksfour marked the issue as satisfactory

[c4-judge]

thereksfour marked the issue as confirmed for report