ADD-06 MitigationConfirmed

[c4-bot-10]

With the PR addressing QA findings, many, mostly unrelated findings are treated in one go.

We'll address them one by one, but the summary is that we found the applied fixes sound and safe from regressions.

• 111/QA-05 Fix typos multiple instances the changes are obviously sound and only update comments. The iff that was not fixed was misreported.
• 111/QA-13 Remove misleading comments from production the changes also in this case are sound and only update comments.
• 111/QA-17Trade slippage can never be set to the accepted max the change is in line with the documentation. Issues can arise if values larger than MAX_TRADE_SLIPPAGE were allowed, but these still correctly disallowed.
• 109/NC-2 Lack of Zero Address Check for Recipient in contracts/p1/RToken.sol#L183-L183 redeemTo Function The fix is shielding from an obvious caller error, so no risk is foreseen.
• 109/NC-3 Floating Pragma Usage in contracts/libraries/Fixed.sol#L4-L4 The fix pins the solc version to 0.8.19 which is the recommended way of specifying it.
• 108/1 shifLeft == 39 condition in the Fixed.shiftl_toFix function will overflow the FIX_MAX value The fix deviated from the fix recommended in the finding, updating the natspec instead, which is obviously a safer choice in absence of a reason to update the code instead.
• 108/4 Not enough input validation checks for the parameters of the TradePrices struct, in the DutchTrade.init function The fix also in this case shields from an obvious caller error, so the change is sound and no regression risk is foreseen.
• 108/10 Disagreement between the natspec and the logic implementation in the BackingManager.rebalance function The fix also in this case opts for the safer choice of adapting the natspec, so no regression is expected.
• 108/14 Discrepancy in code & comments Also in this case, the fix safely updated comments only.
• 107/18 Inconsistency between doc and code regarding RSR usage in recollateralization Similarily to several of the previous fixes, the fix addressed the inconsistency by updating comments only, so no regressions are expected.
• 34/L-1 Asymmetric decay of Asset saved priced distorts average price The fix applied is as recommended in the findings, and completely mitigates risk to downstream price consumers without introducing new risks.
• 34/L-3 Prime basket weights are not properly validated The fix also in this case shields the protocol from an invalid input and its consequences, so it's consequently safe.
• 10/L-22 The totalDrafts should be updated in the withdraw and cancelUnstake functions The fix provided mitigates the impact of the finding and enforces the invariant on totalDrafts.

[c4-judge]

thereksfour marked the issue as satisfactory

[c4-judge]

thereksfour marked the issue as confirmed for report