Open c4-bot-10 opened 1 month ago
With the PR addressing QA findings, many, mostly unrelated findings are treated in one go.
We'll address them one by one, but the summary is that we found the applied fixes sound and safe from regressions.
iff
MAX_TRADE_SLIPPAGE
solc
0.8.19
totalDrafts
thereksfour marked the issue as satisfactory
thereksfour marked the issue as confirmed for report
With the PR addressing QA findings, many, mostly unrelated findings are treated in one go.
We'll address them one by one, but the summary is that we found the applied fixes sound and safe from regressions.
iff
that was not fixed was misreported.MAX_TRADE_SLIPPAGE
were allowed, but these still correctly disallowed.solc
version to0.8.19
which is the recommended way of specifying it.totalDrafts
.