search

code-423n4 / 2024-09-reserve-mitigation-findings

0 stars 0 forks source link

ADD-04 MitigationConfirmed #38

Open c4-bot-3 opened 2 months ago

c4-bot-3 commented 2 months ago

The PR https://github.com/reserve-protocol/protocol/pull/1197 addresses the QA finding The throttle may be incorrectly updated when dissolving or melting rTokens.

The finding described how the RToken issuance/redemption throttle not being updated in the dissolve(), melt() and mint() functions could cause it to return slightly incorrect values after these operations.

The mitigation introduces a call to update the issuance and redemption throttles in the dissolve() and mint() functions. In the case of the melt() function, the mitigation was left out in favour of lower gas costs because "melting is frequent and always small".

We agree with this observation and consider the issue fixed.

c4-judge commented 2 months ago

thereksfour marked the issue as satisfactory