code-423n4 / loopfi-bug-bounty

5 stars 6 forks source link

CDPVault Contract: Using wrong interest rate #71

Closed c4-bot-5 closed 2 months ago

c4-bot-5 commented 3 months ago

Lines of code

https://github.com/code-423n4/2024-07-loopfi/blob/57871f64bdea450c1f04c9a53dc1a78223719164/src/CDPVault.sol#L468

Vulnerability details

I think the cdp vault should use baseInterestRate instead of baseInterestRateIndex because base interest rate index gives a cumulative linear value and according to docs the base interest should fluctuate

I stand to be corrected

c4-bot-10 commented 3 months ago

Discord id(s) for hunter(s): [object Object]

0xd4n1el commented 2 months ago

Wrong repo