code-Atish / codeEditor

1 stars 10 forks source link

feat: Need changes in Navbar.jsx #28

Closed vaibhavvatsbhartiya closed 3 weeks ago

vaibhavvatsbhartiya commented 4 weeks ago

You need to use react-router-dom such that our navbar start function and also change the name HackerRank-->UptoSkills. Also You need to Name the page accordingly in Navbar.

https://github.com/code-Atish/codeEditor/blob/main/frontend/src/components/Navbar.jsx

chihab1991 commented 3 weeks ago

hi I think i can work on this one.

chihab1991 commented 3 weeks ago

are the these links to different pages? also there are no Services , about or contact pages. please let me know how you want to structure these app so i can configure this router properly

vaibhavvatsbhartiya commented 3 weeks ago

well Services , about or contact are just random names in order to give UI to navbar. mainly we use this nav in order to go to one page to another present in pages section.

chihab1991 commented 3 weeks ago

to create a functioning navbar with react-router-dom we need to modify main.jsx and app.jsx and it will be preferable to create a Layout file where we fix the navbar w and the footer and only change the content of the page with react-router

vaibhavvatsbhartiya commented 3 weeks ago

yes absolutely