search

code-and-effect / effective_addresses

Extend any ActiveRecord object to have one or more named addresses. Includes a geographic region aware custom form input backed by Carmen.
MIT License
22 stars 4 forks source link

Feature/ip-based preselection using optional geocoder #12

Closed rosskevin closed 9 years ago

rosskevin commented 9 years ago

This pull introduces Geocoder for IP-based preselection of city, state, country_code, postal_code. It integrates some conveniences with the coffeescript to clear selection if country changes, as well as a new :field_order so that developers may choose to render fields in a different order. In particular when using IP based detection, it makes more sense to verify country selection first, as four of the other selection are already prefilled based on it's value.

I've detailed the options in the readme, and I think this is a very nice addition. There is no requirement to use Geocoder if one should choose not to, and I don't believe any of the changes have any backwards compatibility implications.

As far as I can tell this is good to release (as long as travis passes).

rosskevin commented 9 years ago

dummy

rosskevin commented 9 years ago

Found a bug with bad ip address, hold on merge.

rosskevin commented 9 years ago

Good to merge.

matt-riemer commented 9 years ago

This is a seriously awesome addition. Great feature @rosskevin !