code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(yet rare&tough alone. Please help/join🧩us👨‍👩‍👧‍👧) ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.32k stars 504 forks source link

Extension Instant Search & Completition #1171

Open ImprovedTube opened 2 years ago

ImprovedTube commented 2 years ago

1. Our search in the extension:

2. bugs since v4.0:

bugs, which always happened:

ImprovedTube commented 1 year ago

👍 @hboyd2003
edit

hboyd2003 commented 1 year ago

@ImprovedTube I see the problem now, thanks for updating the report. It looks like this is an issue with @victor-savinov's Satus library. The version in the ImprovedTube repo is minified so its missing all the readable variable names which makes it hard to understand. @victor-savinov Doesn't have the none-minified version uploaded anywhere so I can't really fix it.

In the future it would be better to have the un-minified version in the repo and just have the minification built into the build script for quicker development.

hboyd2003 commented 1 year ago

@ImprovedTube Also I don't think there exists a bug that is not already an existing feature, so no real use to adding the feature exists label to bugs it should be used for feature requests where the feature exists in another form (such as a feature that exists in another extension)

ImprovedTube commented 1 year ago

Satus

Exactly! Firefox also requires source / unminified.
@hboyd2003 https://github.com/code-for-charity/YouTube-Extension/blob/v4.0/assets/satus/satus.js


i dont recall adding feature exists :D