code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.4k stars 513 forks source link

autoplay:off & playlist-autoplay:off take effect late & affect each other! #1508

Open Anoaxx opened 1 year ago

Anoaxx commented 1 year ago

What do i mean?(Writing Player Autoplay & Playlist Autoplay i mean autoplay options in categories)

If Player Autoplay = 1 & Playlist Autoplay = 1 then both work as intended If Player Autoplay = 0 & Playlist Autoplay = 1 then both works as "intended" If Player Autoplay = 1 & Playlist Autoplay = 0 then... emmm its a mix* if Player Autoplay = 0 & Playlist Autoplay = 0 then both work as "intended"

the difference between intended and "intended" is: intended is intended behaviour, but in commas works as intended, but with a little bit of delay. Sometimes its stops video after 10 seconds, sometimes its stops video after 1 second and sometimes it shows normal "stop" view. I mean this one after you press "stop" shortcut but with player still bufforing in bottom. Sometimes its shows "stop" view for a second or two, and then plays for a few seconds and stops it again and sometimes its dont work at all. Everything depends on how fast video player is loading. Reloading page or opening it in new tab is changing behaviour of this and best option to go to the video in the same tab or even better the same video page. Im suspecting its because Youtube is not require reloading entire page every time, and stores some elements in cache or some other memory etc. In other words: It depends on your internet connection and luck. Im sick of testing this and im literally going insane on how much variety this bug has!

*mix means its sometimes works as "intended" and sometimes is working as intended.

Solution: From the start of the "messing up" the Stopping Autoplay i was saying: The first attempt on this was best. Aka load video the same way as its loads when you press "stop" shortcut button. Aka Thumbnail + little YT logo working as a "start" button. Im not saying this must be replace, but as additionall option to Autoplay? sign me up!

The biggest problem of this one is that Victor was tried to please me with this solution above and add bufforing before starting the video(someones request), but i can assume that something dont work on loading player and its depends on how fast is your connection.

For some time i just leave autoplay = 1 i forgot that something was wrong here. Ugh sorry about that ^^'

ps. i know we dont know each other to much, but this issue was written like 3 hours ago and i finishing this right now cause something happened, everyone got angry, and i cant sleep right now. Fuck me. But here you go. You are more important to me then my last roommates... Have a nice day/evening/night. <3

Anoaxx commented 1 year ago

oh i forgot! Best way to avoid delay, and have the nice thumbnail befor video with pre-bufforing is: Using Queue.

Anoaxx commented 1 year ago

Fuck it im going to sleep. im sitting on this last 3 issues in like 6 hours and in mean time i was arguing about stupid key cause im moving out

ImprovedTube commented 1 year ago

Thank you so much!
Hope your fight settles/settled well! 😱

ImprovedTube commented 1 year ago

if Player Autoplay = 0 & Playlist Autoplay = 0 then both work as "indended"

1511

Anoaxx commented 1 year ago

edited <3

ImprovedTube commented 1 year ago

from reviews:

cw noway Nov23 2022 "Here's a "FIX" for "Videos play for a half second and then pause themselves" that worked for me:

HOW: Toggle on "Playlist Autoplay"

STEPS: Configuration -> Playlist -> (Toggle on / Turn on) "Autoplay" "

Colin Stuart Nov15 2022 "Few new issues just popped up. 1) Two description boxes on YT vids. 2) When you look at the Videos on a channel, it doesn't load them all (only loads a single row of a few of them). 3) Videos play for a half second and then pause themselves. Autoplay is setup correctly. "

buffering

nostalgy @Anoaxx https://github.com/code-for-charity/ImprovedTube-for-YouTube/commit/aa1921106d9061f3fbac10cc3a9d42f1d587983f

Pausing video without buffering causes many issues. We will add option later if we find a solution.

YouTube Center worked for previous version of YouTube which had simpler code.

https://github.com/code-for-charity/ImprovedTube-for-YouTube/issues/506#issuecomment-680545823

ImprovedTube commented 1 year ago

one clue:

Toggle on "Playlist Autoplay"

this shouldnt make a difference... 🤔

https://github.com/code-for-charity/ImprovedTube-for-YouTube/blob/102eea7b30a0a6010ee7ab473452a4bae2421392/content-scripts/website-context/youtube-features/player.js#L17

what about undoing this commit? https://github.com/code-for-charity/ImprovedTube-for-YouTube/pull/1469/commits/4491a2cd74503c3466a3f256f157132768fd6727

https://github.com/code-for-charity/ImprovedTube-for-YouTube/blob/649aa095ad120635265859bfacb1833beff8c525/content-scripts/website-context/youtube-features/player.js#L7-L24

BTW:

ImprovedTube commented 1 year ago

also test #1456

ImprovedTube commented 1 year ago

half fixed or maybe fully?

raszpl commented 1 year ago

If Player Autoplay = 1 & Playlist Autoplay = 1 then both work as intended

Dont know if its related, but enabling "Up next autoplay" for both Player & Playlist doesnt seem to work correctly (4.20) for me when playing a playlist. It will play couple of videos from the playlist but then randomly switch to playing next recommended video as if Player "Up next autoplay" overrode the playlist.

marianomontiel commented 8 months ago

I am experiencing the same issue

ImprovedTube commented 8 months ago

hi @marianomontiel! which variant? thanks!

marianomontiel commented 8 months ago

Every single variant. Sometimes it works when I change a setting, but after a while it stops working again and autoplay defaults to ON.

I tried finding exactly when it's stops working, but I wasn't able to replicate it, switching tabs did not work.

El vie, 5 de ene de 2024, 19:08, ImprovedTube @.***> escribió:

hi @marianomontiel https://github.com/marianomontiel! which variant? thanks!

— Reply to this email directly, view it on GitHub https://github.com/code-charity/youtube/issues/1508#issuecomment-1879313012, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQD2LVKDSZ37HMA4LWMORK3YNB2WHAVCNFSM6AAAAAASLYODFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGMYTGMBRGI . You are receiving this because you were mentioned.Message ID: @.***>