Open FuSan21 opened 1 year ago
Thank you! @FuSan21
so this might be a bug our relatively young feature always had?
Somebody in firefox review said it started ~1 month ago. However we had no updates then until 2 weeks ago
Since allow auto generate
was added, as a subroutine of subtitlesLanguage ( pull request ( https://github.com/code-charity/youtube/commit/1dfdc7d141be5e2d0c7d8e07ce6b249622f5e3e1 by @chiming93 ).
allow auto generate
is not set in storage
bug-fix (all in one line): https://github.com/code-charity/youtube/blob/28cbbbf51a6c2b5e8c280f7021158b06756548d3/js%26css/web-accessible/www.youtube.com/player.js#L129
also made this sub-feature appear accordingly only when the language is set
prior to this @chiming93's PR it also gave the language name to the youtube player, now only the code. guess that doesn't matter
We have been asked about subtitle languages many times. Please come together to specify the ultimate plan. @FuSan21 #628 @yagamiyakumo @engineerbaraazakariya @WesselKroos @gregiv @franktntx @ausers @KovalevArtem #348 #259 @tympapost
( from #1543 )
[scroll down](https://github.com/code-charity/youtube/issues/1647#issuecomment-1498080775) (edit by @ImprovedTube)
## Bug Report: ⚬ *BUG*: "Allow auto generate" and "Language" option interfering with the Subtitles option. When a subtitle is available in video natively it will not turn on the subtitle at all. "Subtitles", "Allow auto generate", "Language" all 3 of these options needs to be turned on for the bug to happen. ⚬ *HOW*: 1. Turn on Subtitles from "Player/Subtitles" 2. Turn on Allow auto generate from "Player/Subtitles" 3. Set Language to "English" from "Player/Subtitles" 4. Check the video https://www.youtube.com/watch?v=2eOg5DoYuwU (or any other video that has native English subtitles available) ⚬ *EXPECTED (/preferred) behavior*: The subtitle is shown when all 3 previously mentioned options are set/turned on. ⚬ *Screenshots*: ![image](https://user-images.githubusercontent.com/35169687/228557272-49e4cd0f-5f18-4035-94b3-6ee708eca45b.png) ## Setup: ⚬ ImprovedTube Version: 4.6.1 ⚬ Browser: Edge 111.0.1661.54 ⚬ OS: Windows 11 ⚬ Device: Desktop