code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.46k stars 524 forks source link

YouTube Captions Search, 2. Comment Search #917 #1660

Open ImprovedTube opened 1 year ago

ImprovedTube commented 1 year ago

from #917

Eugene-Gubar/YCS <3 MIT

Firefox version: https://github.com/pancevac/ytsc-extension

hi @chirag127 🧢👋

Captions search: https://greasyfork.org/en/scripts/440153-youtube-ctrl-f-support/code


  1. Generally, lets also check some of chirag's closed issues again(, who likes to close later) We can respect that but mark them "#unresolved" i https://github.com/code-charity/youtube/issues?q=is%3Aissue+sort%3Aupdated-desc+author%3Achirag127+is%3Aclosed
raszpl commented 1 year ago

for the comment search, Im not a fan of code that downloads something form YT servers https://github.com/pancevac/ytsc-extension/blob/b671e915b7cf51dd7c6a2923d3c83bbc1d0fd54d/src/utils/CommentResource.js#L15 replies.comments.map((comment) => (new ReplyResource(comment)).fetch).reverse() : in case of old video there might be thousands of comments and using this will trigger a storm of fetches.

Caption one is easy, small and to the point. btw caption/subtitles, one nice feature is automatically translating subtitles if not available in selected language. This is a one line of code to implement and saves 5 clicks I just noticed https://github.com/code-charity/youtube/issues/1647

ImprovedTube commented 1 year ago

Caption one is easy

👍 the extra specification in #1647 doesnt make your sentence wrong.

a storm of fetches. (hi! @raszpl!)

There is more to it. (Comments are big. The world spends ~ 1/4 of all time spent on websites on youtube.com alone. Comments can be filtered in more ways. Time-marks are very relevant: https://github.com/code-charity/youtube/issues/1565