code-charity / youtube

[top~1 open YouTube & Video browser-extension] - Enrich your experience & choice! 🧰180+ options & clever features 📌set+forget📌Longest-standing(been tough). Please join🧩us👨‍👩‍👧‍👧 ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.5k stars 527 forks source link

When the reverse playlist option is enabled, the playlist's 'Loop' button has a "1" character flickering on and off inside, and causes tooltips and context menus to instantly close #1683

Closed AngryCarrot789 closed 1 year ago

AngryCarrot789 commented 1 year ago

Bug Report:

BUG: Title, and it also causes a huge amount of lag after around 5-10 minutes; video keep buffering and starts lowering the resolution

HOW: Enable the "reverse playlist" option in the extension (Playlist > Reverse). Then, open a playlist (e.g. uploads from a channel). And then irregardless of if reverse is actually enabled or not, eventually the loop button (on the top left side of the playlist panel) will have a 1 inside that keeps showing and going invisible

It seems to happen more often when it autoplays onto the next video. When you refresh the page, it seems to fix it

EXPECTED (/preferred) behavior: It not to flick and cause all tooltips to instantly close

Screenshots: image

/ ⚬ Context:

Setup:

⚬ ImprovedTube Version: 4.9 ⚬ Browser: OperaGX (latest version; 98.0.4759.64, chromium version 112.0.5615.165). The same thing also happens on microsoft edge (chromium edition, not sure the specific version but it's the latest version) ⚬ Settings: ⚬ OS: Windows 10 ⚬ Device:

Here's the call stack just in case... i tried to figure it out myself but it's hella obfuscated lol image

ImprovedTube commented 1 year ago

hi @AngryCarrot789 thank you so much! may i/we use some of your 200 apps?

  1. While we possibly it in our code quicky, youtube's behavior with this playlist widget also is mysterious from a far yet: https://github.com/code-charity/youtube/issues/1544 (scroll down, no other thread in our repo compares to this)

also

  1. since i first saw the OperaGX ad, i feared the correlation with our users might be significant! - in the mean time we only learnd about a bunch of unique bugs only occuring in OperaGX - still have hopes OperaGX might be changing quickly still - or the correlation might not be that hight (while weighting urgency, starting with Chrome), yet the amount of our OperaGX users seems to only increase /exponentially😪😅
ImprovedTube commented 1 year ago

Please Sponsor us, please? @operasoftware

Wont you?

Then we can fix OperaGX bugs daily & wont even mind to be delivered with it by default 😎

AngryCarrot789 commented 1 year ago

I could be wrong but it seems like it's some sort of recursive call of the ImprovedTube.playlistRepeat() function, in playlist.js (https://github.com/code-charity/youtube/blob/master/js%26css/web-accessible/www.youtube.com/playlist.js), where the 100 is the time in milliseconds?

When you collapse the playlist panel, the header jumps between "Next: " and "End of playlist"

ImprovedTube commented 1 year ago

you're making me feel 🤫😳 you might be a contributor, we've been waiting for @AngryCarrot789

milliseconds

Yes, yet i dont know this code better than you. Lost our author in 2022

... * just in case :D you end up testing repeatedly, i suggest this with alt+x ( chrome://extensions/shortcuts )

AngryCarrot789 commented 1 year ago

I just removed the line setTimeout(function () {ImprovedTube.playlistRepeat()}, 100); and that seemed to fix it. Not sure if it broke the repeat function... but I don't use it anyway so 🙃 File path is: C:\Users\<username>\AppData\Roaming\Opera Software\Opera GX Stable\Extensions\<extension id>\4.9_0\js&css\web-accessible\www.youtube.com\playlist.js

ImprovedTube commented 1 year ago