Prevent from re-renders on changing navlinks

MadhuSaini22 commented 1 year ago

Bug Report:

⚬ BUG: When changing the tabs whole website reload. It's because code is using tag , so we should add Navlink element instead of anchor tag by which we can prevent reloading whole website on changing the tab. ⚬ HOW: Change the navlinks, changing the navlinks whole website reloads. ⚬ ImprovedTube Version:

@my8bird I would love to work on this issue.

1. Thanks for coming & caring! Before submitting, please check if the issue has already been reported ever. With GitHub's issue search (use this link) (else removing "is:issue is:open" from the standard search) -->

2. If you find the issue you can answer/react there to give it your voice (or just say hello :) ),

If the status is "closed" (=fixed) recently, then Web Stores might also be updated soon - if it was closed month or years ago, then it reappeared and must be fixed again.

3. To find the bug: Can you ...?:

...log out? (maybe YouTube is testing a new version while you are logged in)
...deactivate all other extensions running on YouTube? (or use an incognito window after activating this extension to run there / chrome://extensions details chrome://extensions/?id=bnomihfieiccainjcjblhegjgglakjdd )
...open the Browser-console, with the F12-Key, before/when the error occures? (then hopefully you'll see an error message in the console).
- ...copy&paste (or screenshot) the YouTube-DOM shown above the console, just in case YouTube is giving you another version.

⚬ Screenshots:

/ ⚬ Context: / ⚬ EXPECTED (/preferred) behavior: It should not rerender on very click of navbar.

Setup:

⚬ Browser: ⚬ Settings:

⚬ OS: ⚬ Device:

MadhuSaini22 commented 1 year ago

@ my8bird I would love to work on this issue.

AniswagMC commented 1 year ago

I'd love to tackle this issue for you, let me know if you'd like to assign it to me!

ImprovedTube commented 1 year ago

hey, thanks and have fun!

(PS: why would you keep tagging my8bird? )

AniswagMC commented 1 year ago

Do you have a setup documentation anywhere? How do I get this set up on my local machine and start seeing the changes I make? @ImprovedTube

ImprovedTube commented 1 year ago

we might upload the website files at one point.

in the meantime please help us fix the more urgent issue of the extension. To run the extension simply download the repo and go to chrome://extensions

also please help us figure out, why do you guys post on GitHub like in a rush/AI/spam?

AniswagMC commented 1 year ago

I'm not sure I understand. I found this repo online and thought GitHub was the only way for me to get in touch with the organization.

ImprovedTube commented 1 year ago

Hi @AniswagMC :) @Shivam-Batham @nikunjgupta609

This is a browser extension. So it needs no setup.
the project website is hardly relevant.
It is a riddle why many people ask to be assigned & won't contribute. Do teachers tell to do that? or Gurus? i dont know who is a bot, but if you use a bot, please make i transparent and useful.

ImprovedTube commented 1 year ago

aaand the solution is: i forgot hacktoberfest! my bad! thank you!

code-charity / youtube