Hover the header on video page dont hide it entirely...

[Anoaxx]

...and it can be easly seen when u use theatre mode with "full window" player size option

I checked, header is dissapiring but its box its still seen. Probably cause place when box moving is aligned to the centre of height of a box not a bottom of it, and it working only like that on a video page cause i think main page works good.

[ImprovedTube]

with Full Height there only seems to remains some more space, than for the other two options Max width & Fit to window (yet header is invisible)

(the header also appears in grey for a moment while YouTube is loading)

[Anoaxx]

For me its a black strip on all the option u pointed out

[gouravmpk]

assign

[ImprovedTube]

hi! @gouravmpk thanks for caring

[gouravmpk]

Can I have some screen shot of the screen to understand the issue more clearly

[ImprovedTube]

hi @gouravmpk this is all about appeareance > player > size not reaching to the top of the window like it used to. The feature should react on both, youtube's theater mode and youtube's standard player. (And if you end up studying the feature with all options that will be great with or with out this issue, as it used to be our most used feature)

• [ ] 1. when using appeareance > player > size > full height, it used to take 100% of the height except for the ~50px for the header - Or 0 px when appeareance > header > hidden (on a wide screen, this can also increase video size a bit). After changes by YouTube this isn't precise anymore....

  • [ ] 2. For the option hover there currently might also needs to remain a little gap for the hovering to be noticed. So we might need to add a transparent hover zone - a 50px transparent bottom border or anything or.

    • Or easier Make the header background transparent and the opacity 0.0001. (Then the only animation/transition on mouse over needs to be background color and opacity. (The current animation seems unnecessary/ nervous )

  • [ ] 3. You can also try to combine the hidden header with appeareance > player > size > max width in a wide window and full window in a very wide window or theater mode, so that there should also be no gap to the top, as the features should attempt to get all height, if they find the width.

---

( Same applies to the options hidden on video pages & hover on video pages respectively. )

---

( The player size feature also used to react to the sidebar or related videos being hidden. We could fix that too or restructure or rename the the whole feature/s maybe, based on user needs )

• further reading: https://github.com/code-charity/youtube/pull/1798#issuecomment-1773686841

  1602

[Anoaxx]

about animation. Its actually cool, if theres a way to remain it even with removing the gap it would be cool. I know you think is unnecesery, but i think its really fine ^^

[ImprovedTube]

So you (still) like the animation? because you don't need it every time? Just assuming fading in might become the first one listed. To save user's attention(=time). - Won't mind hoarding both of course. (Renaming hover on video page (slide animation) ( Dropdown options space is unlimited)

[Anoaxx]

What do you mean? I would like gap to dissapear, but showing and hiding animation has nothing to do with gap

[ImprovedTube]

Hope the (optional!) complexity didn't overwhelm you @gouravmpk!

if theres a way to remain it

animation has nothing to do with gap

still just thought fading in from transparent is more calm and might take a line of code less as said, hence expecting both options.

While one issue at a time is enough, one cant only care for half a feature. It might be efficient to try to consider the road-net ahead and one can end up fixing two things at once just with the same effort and commenting/planing/helping a 3rd one.

[Anoaxx]

Oh i find something interesting that is cool. I u have header hidden on video page, u can still went into finding it clicking "go to search box" shortcut. Just addition, it would be cool if you would add explaination in that option. Cause im using your extension for a looong time and finding this only now xD

Oh and u cant do that on non-video pages somehow

[ImprovedTube]

@Anoaxx

explanation

let's add a tooltip. I think you nearly earned a PR 🤣

cant .. on non-video pages

can you check for error? do other features als stop working on non-video pages?

[Anoaxx]

@ImprovedTube After new update, the top black space is nowhere to be found, but theres another issue... When im changing my uption to "hover" my entire page is slighty moved up, and even usin "full height" option is leaving ha bar with title on a bottom. I need to investigate more tho, but u can try to reproduce it. My settighs are here: improvedtube (5).zip

[Anoaxx]

After some more tests: I reinstalled extension, and its still making player smaller when u use Hover/hover on video page and somehow with static option.

i changed theme to show it better

[Anoaxx]

oh and after ecent update scrollbars cant be hidden. Somehow any of extensions i got to do that, stopped working. Illl made new issue.

[ImprovedTube]

right, we need to tune one more variable #2027

[Anoaxx]

Emmm... top black bar™️ returned @ImprovedTube

[AyushBarai]

is this issue is closed ?

[ImprovedTube]

hi! @AyushBarai no, just tried the one variable and undid.

[Anoaxx]

@ImprovedTube After new update on Chrome Webstore for beta(4.928) header is fully hidden, but using its still causing to player not being on full height, even if player size is set to full height.

[Anoaxx]

PS. Its a little bit smaller when u scale page to be smaller 🤷

[Anoaxx]

I can suggest to make additional option that u can turn on, ane then u can choose the header behaviour seperatly for home page and video page.

[ImprovedTube]

which two will you chose?

[Anoaxx]

What do you mean exactly?