search

code-charity / youtube

[top~1 open YouTube & Video web-extension] Enrich your experience & choice! 🧰180+ options & clever features📌set+forget📌Longest-standing(yet rare&tough alone. Please help/join🧩us👨‍👩‍👧‍👧) ..⋮ {playback|content discovery|player|extra buttons|distractions|related videos|shorts|ads|quality|codec|full tab|full screen}
http://improvedtube.com
Other
3.33k stars 503 forks source link

Playback speed not working anymore #1856

Open killthe3vil opened 7 months ago

killthe3vil commented 7 months ago

it been few days the playback speed not working anymore.

shadow-ryu commented 7 months ago

I'm interested in tackling this task, but I would appreciate it if additional information could be provided. :)

ImprovedTube commented 7 months ago

hi @killthe3vil what version?

@shadow-ryu Awesome!!

cant say much. some of our stuff needs maintenance when youtube's DOM / CSS changes, but html5 browser standard playback features shouldnt break and youtube player's functions are well known / might not change.

in the repo a complex enhancement deciding what's music (no speed up) was just added a few days ago. This will only reach stores today or tomorrow.

killthe3vil commented 7 months ago

im not sure what info you want, i will just show everything i can Window 10 Chrome Version 119.0.6045.160 (Official Build) (64-bit) ImproveTube Version 4.408

shadow-ryu commented 7 months ago

ok

killthe3vil commented 7 months ago

@shadow-ryu Appreciated for the help!~

shadow-ryu commented 7 months ago

@killthe3vil can u share the local setup guide as I cant find the same.

killthe3vil commented 7 months ago

@shadow-ryu local setup guide? i'm not sure what it is. but somehow it fixed today, are you doing something already?

ImprovedTube commented 7 months ago

hi! @killthe3vil, i should have asked if you did anything differently when it didn't work and for how long.

(the update(v4.443) was only approved for our chrome webstore beta testing version yet)

setup guide

the repo is also the extension. no building required. (more: https://github.com/code-charity/youtube/wiki/Contributing#Development ) hi @shadow-ryu how are you?

killthe3vil commented 7 months ago

Hi @ImprovedTube nop, i did nothing on setting after i done all the customize, it didn't work like 1 weeks ago until today.

shadow-ryu commented 7 months ago

Hey @killthe3vil its working on my side too

killthe3vil commented 7 months ago

@shadow-ryu ya it weird that it fixed itself by today

shadow-ryu commented 7 months ago

we can keep this issue on monitoring?

killthe3vil commented 7 months ago

it is me only or the function not working again?

ImprovedTube commented 7 months ago

hi @killthe3vil thanks, we can just assuming it works for most people most of the time and we just had a bug with applying it to embedded youtube players before. ( assumably you werent confused by the music exclusion either. )

cant say much. some of our stuff needs maintenance when youtube's DOM / CSS changes, but html5 browser standard playback features shouldnt break and youtube player's functions are well known / might not change.

(didnt mean to say there is no bug, just that we should fix it already if any.)

@shadow-ryu

yes, looking forward to whatever we might discuss next.

xeophyte commented 7 months ago

I just want to add that with these settings on v4.443: image music recognizing doesn't work very well, or maybe I don't understand some functions. When I open a video with some talking, I get 1.25 (as I want), but then when I go to music video, it stays at 1.25 (I want 1.0). Shouldn't there be an option/function "Don't force playback speed for music"?

Anoaxx commented 7 months ago

tried reinstall?

xeophyte commented 7 months ago

Yes, I reinstalled and restored settings and still got 1.25 on music.

ImprovedTube commented 7 months ago

@xeophyte how many examples did you try? please share all or look for the reason they were missed

xeophyte commented 7 months ago

On at least 15 videos. Actually the 1.25 speed often doesn't work even on talking movies, like https://www.youtube.com/watch?v=lRvXAU9_sfc or https://www.youtube.com/watch?v=DKBxkrUPCbs even after many refreshes. Sometimes it works, but then music doesn't, like I play music video, get 1.0, then go directly to talking, get 1.25, then go back to music and 1.25 stays. But maybe it's connected to my other bugs - Autoplay never works - I have to play manually every new video (besides playlists) and Show description - set to Always sometimes doesn't work.

ImprovedTube commented 7 months ago

@xeophyte so it worked better for you before? (v4.408, v4.404, ... ?)

back

with browser nagivation back arrow?

maybe this code doesnt always run for you when a video starts? do all these other features, such as the permanent volume, also work - or fail at the same times? https://github.com/code-charity/youtube/blob/7e2519ad13dd1bed6e5c697b0fd00d81b705479a/js%26css/web-accessible/functions.js#L344-L365

ImprovedTube commented 7 months ago

@xeophyte forgot some of the code about music is disabled, so that's an explanation. https://github.com/code-charity/youtube/blob/7e2519ad13dd1bed6e5c697b0fd00d81b705479a/js%26css/web-accessible/www.youtube.com/player.js#L150 to confirm this please check if everytime it fails, the browser console sais 5 times: Error: Invidious API: ... and eventually (~10s later) Error parsing id="scriptTag"\'s JSON: .....

xeophyte commented 7 months ago

so it worked better for you before? (v4.408, v4.404, ... ?)

I test this feature only for few days, don't know how it was earlier.

with browser nagivation back arrow?

Yes, and also when I click music video directly from the right related list.

Similar test: I play talking video (sets itself on 1.25), go to music from related (stays at 1.25), set it to 1.75, go to another talking (sets itself on 1.25), go to some music (stays at 1.25), set it to 2.0, go to some music (stays at 2.0).

It doesn't matter if the next video is opened by click or using the previous/next page button, the effect is the same. In other words: the speed setting for a music video is set to the one that was last set, regardless of whether the last page was a video with talking or music. On the current browser tab of course.

Maybe it's somehow related to YT itself remembering the speed setting of a given video?

maybe this code doesnt always run for you when a video starts? do all these other features, such as the permanent volume, also work - or fail at the same times?

I don't know how to test it.

image

But I still feel it's connected to my Autoplay sometimes not working. When I open some YT tab in the background and go to that tab, the video doesn't play, have to run manually.

ImprovedTube commented 7 months ago

thank you! @xeophyte you can watch the browser console live to see what happens when. (busy seconds. Can also enable top view timestamps..)

mrlinuxfish commented 6 months ago

I found some videos get the automatic speed and some do not. I am guessing this has to do with the category but I can't find where to see what categories a video belongs to

killthe3vil commented 6 months ago

@mrlinuxfish yup that how the situation to me as well, could not figure out what the issue

ImprovedTube commented 6 months ago

thanks! @mrlinuxfish @killthe3vil

maybe it happens only when excluding music and only after clicking a related video only? (then to see the tags efficiently we ask a random invidious API node but some may be down and it is retried for a few seconds. should be robust 🤔)

category

hoped we'd have an easy bug, that always excludes education videos as the switch is new, but maybe not

you can see the category called genre in the browser console log as in the screenshot above our comments using the word genre as it is the same one youtube used (even though it is about 1/3 as common and more seasonal (summer lows) https://trends.google.com/trends/explore?date=all&q=genre,category&hl=en

ImprovedTube commented 5 months ago

let us know your further experience? @mrlinuxfish @killthe3vil @shadow-ryu @xeophyte

killthe3vil commented 5 months ago

let us know your further experience? @mrlinuxfish @killthe3vil @shadow-ryu @xeophyte

i think so far so good now, but sometime will not working like 10 out of 1 time.

xeophyte commented 5 months ago

Looks like it's working for me on 4.700 (maybe one out of 10 times it doesn't work), although sometimes switching to the appropriate speed takes up to 10 seconds. Also, I found new bug related. I set the default speed to 1.25, so non-music is at that speed and music is at 1.0. When I play a playlist (e.g. with music) and go to for example subscription page or the home page, the playback speed in the miniplayer is changed to the default one, i.e. in my case the music speeds up to 1.25.

Anoaxx commented 5 months ago

Looks like it's working for me on 4.700 (maybe one out of 10 times it doesn't work), although sometimes switching to the appropriate speed takes up to 10 seconds. Also, I found new bug related. I set the default speed to 1.25, so non-music is at that speed and music is at 1.0. When I play a playlist (e.g. with music) and go to for example subscription page or the home page, the playback speed in the miniplayer is changed to the default one, i.e. in my case the music speeds up to 1.25.

Try open video in a new tab and wait that 10 second before tuning into it. It should work from a strat. Some things need some time to load.

xeophyte commented 5 months ago

It doesn't make sense when the playlist is playing, after all, that's why it's there so that you don't have to open every video in a new tab. I would prefer to be able to set the default speed to 1.0, and for IYT to switch the music to a my different value.

Anoaxx commented 5 months ago

Option to control speed on playlist or exclude playlist from other vieos could be cool option. Remember @ImprovedTube WE DON JUST HAVE PLAYLISTS, there are queues, mixes and probably something more.

xeophyte commented 4 months ago

@ImprovedTube This option seems to work in such a way that each video is first set to a given speed and then its speed is changed depending on whether it is, for example, a musical video or not. Could it be modified so that the user's speed is switched on AFTER the type of video is detected? Maybe this would eliminate the problem of changing the speed during playback at the beginning of the video.

ImprovedTube commented 4 months ago

hi! @xeophyte yes, when music only is indicated as in youtube's catalogue /buyable, below the video-descriptions. How often?

yes, inversely (and originally for us), these few music videos can start slow instead. But the feature is used for speed-watching mostly and the music sub-option enabled by default for this feature. So @eyevou thought of the current order And maybe hurried users like it like now.

As of the edit history anyone and chatgpt (next to me) can can now add a sub-sub-option to allow both detection orders. ( long before/easier before ultimately one day our music detection should even be immediate always, if ever. )

xeophyte commented 4 months ago

I didn't understand any of it. I just want to play music videos at 1.0 when the Playback speed is set to 1.25. Now it starts playing at 1.25 or it is set like that all the time.

ImprovedTube commented 4 months ago

all time time

really? @xeophyte: in other & shorter words: It is supposed to:

ImprovedTube commented 4 months ago

just fixed something: https://github.com/code-charity/youtube/commit/3809d3b1448bd1bd7c400149c43e7be8fadd119c

xeophyte commented 3 months ago

just fixed something: 3809d3b

  • does the bug appear only with new tabs or new sessions? (not after navigating related videos within youtube) @xeophyte

both

raszpl commented 1 month ago

this https://github.com/code-charity/youtube/blob/85bf12458d10dbc15ab4d8da057da01b5d8e152d/js%26css/web-accessible/www.youtube.com/player.js#L82-L204

really needs refactoring, reformatting and cleaning up