Blocked video titles not visible in extension's UI when using dark theme

[Gitoffthelawn]

Bug Report:

⚬ BUG: Blocked video titles not visible in extension's UI when using dark theme.

⚬ STR:

1. Enable the extension's dark theme.
2. Block any video on YouTube.
3. Open the extension's UI.
4. Click on "Blacklist" (time to make that "Blocklist").
5. Notice that the blocked video titles are not visible in the extension's UI. I haven't taken a close look at it yet, but good chance it is due to dark text on a dark background (common bug).

Solution: Explicitly set the foreground colour of the text. Likely need to do the same for blocked channel names.

⚬ Extension: v4.443 ⚬ Browser: Firefox 115ESR ⚬ OS: Linux

[ImprovedTube]

hi! @Gitoffthelawn thanks

• the titles aren't actually there (noticed with right click "inspect". so we have to check the feature's code)
• you can search&replace lacklist in the repo

[raszpl]

I can see them clearly in the UI

they are hard to see on the page due to .it-blocklisted-video {opacity: 0.15;} but that is by design

[Gitoffthelawn]

@raszpl Are you looking in the extension's UI or YouTube's UI? Please see Steps 3-5 in the STR.

[raszpl]

stock 4.704 install, dark theme. I bumped bightnes so the blocked hidden video is also visible:

EDIT: you said Dark theme, dark theme is broken for me in 4.704 :) works only in extension menu but page is while (broken cookie). I also send fix for that. Still in the extension UI it looks exactly like in above picture, blocked videos are in white on black,

But looking at devtools script is crashing, that can affect the extension in bad ways

functions.js:131 Uncaught TypeError: Cannot read properties of undefined (reading 'flexible-item-buttons')
    at ImprovedTube.ytElementsHandler (functions.js:131:41)

    } else if (name === 'YTD-MENU-RENDERER' && node.classList.contains('ytd-video-primary-info-renderer')) {
        if(document.documentElement.dataset.pageType === 'video'){
            this.hideDetailButton(node.$['flexible-item-buttons'].children);
        }

Its already fixed by me in the repo https://github.com/code-charity/youtube/pull/2059 just needs new release